Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accessibility] Fix teaching tip name property in buttons #6897

Merged
merged 4 commits into from
Apr 1, 2022
Merged

[Accessibility] Fix teaching tip name property in buttons #6897

merged 4 commits into from
Apr 1, 2022

Conversation

bkudiess
Copy link
Contributor

@bkudiess bkudiess commented Mar 29, 2022 •
edited by ranjeshj
Loading

When using screen readers, teaching tip action and close buttons where reading just "button" instead of text property.

Adding on property changed listener to button's content presenter and updates automation property name with new value to fix the issue.

Fixes internal bug 38395706
Fixes #6867

@bkudiess bkudiess requested review from ranjeshj and kmahone March 29, 2022 19:51
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Mar 29, 2022
@bkudiess
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kmahone
Copy link
Member

kmahone commented Mar 29, 2022

Please add a test for this scenario.

kmahone
kmahone requested changes Mar 29, 2022
View reviewed changes
Copy link
Member

@kmahone kmahone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@ojhad ojhad added area-TeachingTip team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Mar 29, 2022
@bkudiess
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bkudiess
Copy link
Contributor Author

bkudiess commented Apr 1, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

kmahone
kmahone approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@kmahone kmahone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bkudiess bkudiess merged commit 9aee101 into main Apr 1, 2022
@bkudiess bkudiess deleted the user/bakudies/narrator-teachingtip branch April 1, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmahone kmahone kmahone approved these changes

@ranjeshj ranjeshj Awaiting requested review from ranjeshj

Assignees
No one assigned
Labels
area-TeachingTip team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TeachingTips][Accessibility] Action buttons name not read by narrator
3 participants
@bkudiess @kmahone @ojhad